New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FF51] Search partially broken #676

Closed
SammysHP opened this Issue Jan 31, 2017 · 16 comments

Comments

Projects
None yet
7 participants
@SammysHP
Member

SammysHP commented Jan 31, 2017

Issue type:
  • Bug report
Version:

Latest version including the patch from @ma8ma

Description:

Search for a string. The first press of Enter highlights a match, but the search prompt stays active. Pressing Enter a second time fails with following error:

TypeError: findbar._setHighlightTimeout is not a function
Expected behavior:

Prompt closes, no error.

Steps to reproduce:
  1. /aEnter
  2. Enter
@marza91

This comment has been minimized.

Show comment
Hide comment
@marza91

marza91 Jan 31, 2017

I also have this issue, Firefox 51.0.1 on linux. It might not be obvious, but the search actually works on the second enter key-press (although the error message shows up). Pressing 'n' starts browsing through matches as normal.

marza91 commented Jan 31, 2017

I also have this issue, Firefox 51.0.1 on linux. It might not be obvious, but the search actually works on the second enter key-press (although the error message shows up). Pressing 'n' starts browsing through matches as normal.

SammysHP added a commit to SammysHP/vimperator-labs that referenced this issue Jan 31, 2017

Fix #676: Search partially broken
_setHighlightTimeout was removed in FF51. This might not be backward
compatible and has also a little quirk: If you disable highlighting it
will be disabled on all tabs. Pressing "n" on another tab does not
highlight again except if you disable highlighting for that tab.

This might be an issue with global/local handling of the findbar.
@SammysHP

This comment has been minimized.

Show comment
Hide comment
@SammysHP

SammysHP Jan 31, 2017

Member

I don't want to open a PR yet because I'm not sure if this is enough and is backward compatible.

Member

SammysHP commented Jan 31, 2017

I don't want to open a PR yet because I'm not sure if this is enough and is backward compatible.

@ma8ma

This comment has been minimized.

Show comment
Hide comment
@ma8ma

ma8ma Jan 31, 2017

Contributor

@SammysHP b266c23 works highlighting on 45.7.0 ESR, but state of "Highlight All" toggle button (it's in findbar) doesn't change turn on, and if continue searching another word in the state of off, highlighting doesn't remove from previous words.
P.S. :set nohlsearch has worked fine for various words.

Contributor

ma8ma commented Jan 31, 2017

@SammysHP b266c23 works highlighting on 45.7.0 ESR, but state of "Highlight All" toggle button (it's in findbar) doesn't change turn on, and if continue searching another word in the state of off, highlighting doesn't remove from previous words.
P.S. :set nohlsearch has worked fine for various words.

ipwnponies added a commit to ipwnponies/dotfiles that referenced this issue Mar 2, 2017

Monkey patch search highlighting in vimperator
* Fix for this issue: vimperator/vimperator-labs#676
* Commit: vimperator/vimperator-labs@b266c23 Please enter the commit message for your changes. Lines starting

dset0x added a commit to dset0x/vimperator-labs that referenced this issue Mar 12, 2017

dset0x added a commit to dset0x/vimperator-labs that referenced this issue Mar 12, 2017

dset0x added a commit to dset0x/vimperator-labs that referenced this issue Mar 12, 2017

dset0x added a commit to dset0x/vimperator-labs that referenced this issue Mar 12, 2017

@gkatsev gkatsev closed this in #737 Mar 13, 2017

gkatsev added a commit that referenced this issue Mar 13, 2017

@llinfeng

This comment has been minimized.

Show comment
Hide comment
@llinfeng

llinfeng Mar 20, 2017

@gkatsev How to apply the fix? I don't find an update through the Extensions page in my Firefox. The current version is updated on February 18; is there a place to download the latest *.xpi file? Thank you for the fix!

llinfeng commented Mar 20, 2017

@gkatsev How to apply the fix? I don't find an update through the Extensions page in my Firefox. The current version is updated on February 18; is there a place to download the latest *.xpi file? Thank you for the fix!

@SammysHP

This comment has been minimized.

Show comment
Hide comment
@SammysHP

SammysHP Mar 20, 2017

Member

We do not provide nightly builds (yet) and there was no release after the fix.

Member

SammysHP commented Mar 20, 2017

We do not provide nightly builds (yet) and there was no release after the fix.

@llinfeng

This comment has been minimized.

Show comment
Hide comment
@llinfeng

llinfeng Mar 20, 2017

@SammysHP Oh, then, are there instructions on how to build the *.xpi file on the user's end? I would like to give it a try if it is not too complicated. Or, should I be underestimating the effort it takes to build an add-on for Firefox, I will happily wait for the new release. Is the fix scheduled at any chance? Thanks a lot!

llinfeng commented Mar 20, 2017

@SammysHP Oh, then, are there instructions on how to build the *.xpi file on the user's end? I would like to give it a try if it is not too complicated. Or, should I be underestimating the effort it takes to build an add-on for Firefox, I will happily wait for the new release. Is the fix scheduled at any chance? Thanks a lot!

@SammysHP

This comment has been minimized.

Show comment
Hide comment
@SammysHP

SammysHP Mar 21, 2017

Member

Since a few weeks ago it is not possible anymore to sign new addon. So you would have to build an unsigned addon and an unbranded version of Firefox (developer build won't work as well because XUL addon support will be disabled in a few weeks).

Member

SammysHP commented Mar 21, 2017

Since a few weeks ago it is not possible anymore to sign new addon. So you would have to build an unsigned addon and an unbranded version of Firefox (developer build won't work as well because XUL addon support will be disabled in a few weeks).

@SammysHP

This comment has been minimized.

Show comment
Hide comment
@SammysHP

SammysHP Mar 21, 2017

Member

All instructions are in the README btw.

Member

SammysHP commented Mar 21, 2017

All instructions are in the README btw.

@llinfeng

This comment has been minimized.

Show comment
Hide comment
@llinfeng

llinfeng Mar 21, 2017

@SammysHP Thank you for clarifying! The README is super clear.

llinfeng commented Mar 21, 2017

@SammysHP Thank you for clarifying! The README is super clear.

@limansky

This comment has been minimized.

Show comment
Hide comment
@limansky

limansky Mar 29, 2017

@SammysHP Do you have any expectations for the fixed release date?

limansky commented Mar 29, 2017

@SammysHP Do you have any expectations for the fixed release date?

@SammysHP

This comment has been minimized.

Show comment
Hide comment
@SammysHP

SammysHP Mar 29, 2017

Member

Once @maxauthority or @gkatsev decides to make a new release it will take approximately two weeks for Mozilla to review the addon and sign it.

@maxauthority, @gkatsev: What do you think? There were some fixes since the last release.

Member

SammysHP commented Mar 29, 2017

Once @maxauthority or @gkatsev decides to make a new release it will take approximately two weeks for Mozilla to review the addon and sign it.

@maxauthority, @gkatsev: What do you think? There were some fixes since the last release.

@tooxie

This comment has been minimized.

Show comment
Hide comment
@tooxie

tooxie Apr 24, 2017

👍

Please consider releasing this fix asap. Thanks!

tooxie commented Apr 24, 2017

👍

Please consider releasing this fix asap. Thanks!

@limansky

This comment has been minimized.

Show comment
Hide comment
@limansky

limansky Sep 24, 2017

Any news on this issue? Is vimperator still alive?

limansky commented Sep 24, 2017

Any news on this issue? Is vimperator still alive?

@llinfeng

This comment has been minimized.

Show comment
Hide comment
@llinfeng

llinfeng Sep 24, 2017

@limansky I am not part of the development team, but I have strong faith in their continuous effort. If there is something specific that is bothering you, please try to build the latest version yourself. The README file is super clear. [Hope this helps.]

llinfeng commented Sep 24, 2017

@limansky I am not part of the development team, but I have strong faith in their continuous effort. If there is something specific that is bothering you, please try to build the latest version yourself. The README file is super clear. [Hope this helps.]

@limansky

This comment has been minimized.

Show comment
Hide comment
@limansky

limansky Sep 26, 2017

@llinfeng Thanks for your reply.

Even though the readme is super clear, I think that it's not a such a big deal to make a new release instead of suggesting to build signed plug-in to all users (because one of the core features is broken).

limansky commented Sep 26, 2017

@llinfeng Thanks for your reply.

Even though the readme is super clear, I think that it's not a such a big deal to make a new release instead of suggesting to build signed plug-in to all users (because one of the core features is broken).

@llinfeng

This comment has been minimized.

Show comment
Hide comment
@llinfeng

llinfeng Sep 26, 2017

@limansky As a "free-rider" myself, I would suspect that the it may become extremely hard to push new releases onto the Mozilla "market". If you try to build it yourself, you will see how intricate things are when it comes to crafting those "certified" plug-ins. I would think that building our own version is a good temporary solution.

(Also, I am thankful that the vimperator project is not abandoned at all. For example, Pentadactyl has been long dead, and I was extremely disheartened when I learned about it.)

llinfeng commented Sep 26, 2017

@limansky As a "free-rider" myself, I would suspect that the it may become extremely hard to push new releases onto the Mozilla "market". If you try to build it yourself, you will see how intricate things are when it comes to crafting those "certified" plug-ins. I would think that building our own version is a good temporary solution.

(Also, I am thankful that the vimperator project is not abandoned at all. For example, Pentadactyl has been long dead, and I was extremely disheartened when I learned about it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment