Remove unnecessary Iterator loop in history.get - #517
Merged
Conversation
This seems to be not necessary and it is causing issues particularly in firefox 47, there query is a "XPCWrappedNative_NoHelper" and we can't modify it which is what this loop tries to do. Wrapping it in a try/catch does fix the issue as well but removing it altogether seems to also fix it and seems that there are no adverse effects.
Member
|
👍 for FF 45.1.1 ( I just reinstalled my desktop so I don't have my VMs to test different versions, unfortunately. |
Member
Author
|
Going to merge this. We can always make another patch. |
Member
|
Sounds good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be not necessary and it is causing issues particularly in
firefox 47, there query is a "XPCWrappedNative_NoHelper" and we can't
modify it which is what this loop tries to do.
Wrapping it in a try/catch does fix the issue as well but removing it
altogether seems to also fix it and seems that there are no adverse
effects.
Can someone give this a shot on various some versions of firefox?