Vincent Dieltiens vincentdieltiens

@vincentdieltiens

What's the result of the $result ?. Just print it before the line : $decoded = json_decode(substr($result, strpos($result, '{')), true);

@vincentdieltiens

Because it's not the purpose of this library.

@vincentdieltiens

elephant.io is for building clients not servers.

vincentdieltiens commented on pull request Wisembly/elephant.io#104
@vincentdieltiens

Anything else to change ?

vincentdieltiens commented on pull request Wisembly/elephant.io#104
@vincentdieltiens

Sorry :D

@vincentdieltiens
  • @vincentdieltiens 386cba1
    Remove echo from 1.x example
vincentdieltiens commented on pull request Wisembly/elephant.io#104
@vincentdieltiens

Actually, I ran composer outside Elephant.io (it is a dependency of a testing project). I just run composer inside Elephant.io project, it works ;-)

@vincentdieltiens
  • @vincentdieltiens ba815d1
    Fixes path to the autoload.php in examples
vincentdieltiens commented on pull request Wisembly/elephant.io#103
@vincentdieltiens

(also as having a getOrigin method... what about the other type of headers ? I know I said that implementing those is not the goal of the library …

@vincentdieltiens

In fact, I think it's a good idea to correctly set the origin header in the upgradeTransport request. Setting the origin as "*" is inconsistent if …

@vincentdieltiens

So it should be in a comment :-P Seems to work well, but OK, I'll do it in another PR

vincentdieltiens commented on pull request Wisembly/elephant.io#104
@vincentdieltiens

I just created the new examples but it seems that the path to the vendor autoload for the other examples are incorrect ?

@vincentdieltiens
@vincentdieltiens
  • @vincentdieltiens 5cfc5e0
    Add missing doc parameter for method
@vincentdieltiens

See the PR #103

@vincentdieltiens

I can help to write docs. Why not write correctly the phpdoc and generate documentation ?

@vincentdieltiens
Allowing to set several namespaces during one session
5 commits with 45 additions and 6 deletions
vincentdieltiens commented on pull request Wisembly/elephant.io#103
@vincentdieltiens

I think now that the PR is good :)

@vincentdieltiens
  • @vincentdieltiens 14cce47
    Correctly use static::CLOSE and static::MESSAGE respectively for clos…
vincentdieltiens commented on pull request Wisembly/elephant.io#103
@vincentdieltiens

I think now that the PR is good

@vincentdieltiens
  • @vincentdieltiens 6ec11b6
    Correctly set the origin in the upgrade request (required by v0.9 of …
@vincentdieltiens
  • @vincentdieltiens b94223f
    Fixes timeout bug that was not attached to the HTTP context