Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Report unsupported platform message to stderr rather than stdout #4

Merged
merged 3 commits into from Feb 26, 2012

Conversation

Projects
None yet
2 participants
Contributor

DougBurke commented Feb 22, 2012

The main change here is to use 'hPutStrLn stderr' rather than 'putStrLn' for un-supported systems; I have a speccific reason for this (simplifies my workflow slightly), but it feels better to me to have this be written to stderr.

The other two changes are more cosmetic.

Thanks, Doug

Owner

vincenthz commented Feb 26, 2012

The pull request is fine, however wouldn't it be better to just have verifyChain working ?

a bunch of code has been already written for others platform that i don't have, however they haven't been tested in the tls context. it should just be a matter of testing with the conditional removed for your platform and reporting if it is working.

Contributor

DougBurke commented Feb 26, 2012

I had a quick look at certificate handling on OS-X, but quickly came to the conclusion that my spare time was insufficient for the task, and I do not have a Windows machine to test on!

Owner

vincenthz commented Feb 26, 2012

I'm just asking you to test the OS-X part, not the windows part. All the certificate handling for OS-X should be already in place in the 'certificate' package.

vincenthz added a commit that referenced this pull request Feb 26, 2012

Merge pull request #4 from DougBurke/master
Report unsupported platform message to stderr rather than stdout

@vincenthz vincenthz merged commit b3416be into vincenthz:master Feb 26, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment