New ciphers for TLS 1.2 and TLS 1.3 #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ciphers are always taken from the client/server local configuration.
| @@ -163,17 +162,18 @@ handshakeClient' cparams ctx groups mcrand = do | |||
| return $ Just $ toExtensionRaw $ KeyShareClientHello [ent] | |||
| | otherwise = return Nothing | |||
|
|
|||
| sessionHash sdata = case cipherIDtoCipher13 (sessionCipher sdata) of | |||
There was a problem hiding this comment.
Thank you for removing cipherIDtoCipher13 . 👍
kazu-yamamoto
approved these changes
Oct 10, 2018
|
I have confirmed that |
|
Thanks for your tests. I think it will be possible to merge TLS13 record modules with the ones used for previous versions. In the end, there are very few differences:
That's all I see. The compression step can be put back since it is a no-op. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following:
The nonce construction of TLS 1.3 is applied to TLS 1.2 when
bulkExplicitIVis 0 instead of 8, which I believe is the correct condition.I also remove
cipherIDtoCipher13so that custom ciphers can be used with TLS 1.3 too.