New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to lame 1.2.3 - fixes compatibility w/ newer node versions #12

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@kauffecup

kauffecup commented Sep 30, 2015

On node > 0.11.x lame will not install properly. Updating to newest lame version fixes this. The errors during installation were:

8 warnings generated.
  CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/feature.o
  CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/dct64_x86_64.o
  CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/dct64_x86_64_float.o
  CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth_s32.o
  CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth_real.o
  CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth_stereo_x86_64.o
  CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth_stereo_x86_64_float.o
  CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth_stereo_x86_64_s32.o
  CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth_x86_64.o
  CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth_x86_64_s32.o
  CC(target) Release/obj.target/mpg123/deps/mpg123/src/libmpg123/synth_x86_64_float.o
  LIBTOOL-STATIC Release/libmpg123.a
  CC(target) Release/obj.target/lamevectorroutines/deps/lame/libmp3lame/vector/xmm_quantize_sub.o
  LIBTOOL-STATIC Release/liblamevectorroutines.a
  CXX(target) Release/obj.target/bindings/src/bindings.o
../src/bindings.cc:29:15: error: calling a protected constructor of class 'v8::HandleScope'
  HandleScope scope;
              ^
/Users/jkaufman/.node-gyp/0.12.7/deps/v8/include/v8.h:816:13: note: declared protected here
  V8_INLINE HandleScope() {}
            ^
@miduku

This comment has been minimized.

Show comment
Hide comment
@miduku

miduku commented Jan 18, 2016

+1

@rreusser

This comment has been minimized.

Show comment
Hide comment
@rreusser

rreusser Feb 14, 2016

Worked perfectly but took me a half hour to track down. Merge would be greatly appreciated!

See also: TooTallNate/node-lame#60

rreusser commented Feb 14, 2016

Worked perfectly but took me a half hour to track down. Merge would be greatly appreciated!

See also: TooTallNate/node-lame#60

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost commented May 2, 2016

+1

@gorghoa

This comment has been minimized.

Show comment
Hide comment
@gorghoa

gorghoa Sep 3, 2016

@vincentsaluzzo, could you merge this one? Any attempt to install your project on modern nodejs is failing

gorghoa commented Sep 3, 2016

@vincentsaluzzo, could you merge this one? Any attempt to install your project on modern nodejs is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment