Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Merge pull request #4860 from gtorodelvalle/feature-dialer-missed-cal…

…ls-highlighting

Feature dialer missed calls highlighting
  • Loading branch information...
commit f81353375d03df02e8d414e1be62b371fd646b62 2 parents 3c12fdd + 99711fe
@vingtetun authored
View
19 apps/communications/dialer/js/recents.js
@@ -400,8 +400,12 @@ var Recents = {
' <section class="primary-info ellipsis">' +
recent.number +
' </section>' +
- ' <section class="secondary-info ellipsis">' +
- Utils.prettyDate(recent.date) +
+ ' <section class="secondary-info">' +
+ ' <span class="call-time">' +
+ Utils.prettyDate(recent.date) +
+ ' </span>' +
+ ' <span class="call-additional-info ellipsis">' +
+ ' </span>' +
' </section>' +
' </div>' +
' </section>' +
@@ -497,14 +501,9 @@ var Recents = {
}
var phoneNumberAdditionalInfo = Utils.getPhoneNumberAdditionalInfo(
phoneNumber, contact);
- var secondaryInfo = logItem.querySelector('.secondary-info');
- var secondaryInfoText = secondaryInfo.innerHTML.trim();
- var secondaryInfoIndex = secondaryInfoText.indexOf('&nbsp;&nbsp;&nbsp;');
- if (secondaryInfoIndex > 0) {
- secondaryInfoText = secondaryInfoText.substring(0, secondaryInfoIndex);
- }
- secondaryInfo.innerHTML = secondaryInfoText +
- '&nbsp;&nbsp;&nbsp;' + phoneNumberAdditionalInfo;
+ var phoneNumberAdditionalInfoNode = logItem.
+ querySelector('.call-additional-info');
+ phoneNumberAdditionalInfoNode.textContent = phoneNumberAdditionalInfo;
logItem.classList.add('isContact');
logItem.dataset['contactId'] = contact.id;
} else {
View
8 apps/communications/dialer/style/commslog.css
@@ -310,11 +310,11 @@ button::-moz-focus-inner {
background-image: url('images/CallLog_30x30_missed.png');
}
-.log-item.highlighted[data-type='incoming'] .secondary-info {
+.log-item.highlighted[data-type='incoming'] .call-time {
color: red !important;
}
-.log-item.highlighted[data-type='incoming-refused'] .secondary-info {
+.log-item.highlighted[data-type='incoming-refused'] .call-time {
color: red !important;
}
@@ -342,6 +342,10 @@ button::-moz-focus-inner {
color: #5b5b5b;
}
+.call-additional-info {
+ padding-left: 0.7rem;
+}
+
.call-log-contact-photo {
float: left;
height: 100%;
Please sign in to comment.
Something went wrong with that request. Please try again.