Added a failing test for custom alphabet and long salt #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the same code, no matter how many 'a' you append to the salt of the last hashids instance)
|
It seems the test fails, I suggest use forums for questions. If you find a bug, please submit a new pull request. |
|
Yes, the test failed because you asked me to add a failing test... the test should pass, but is failing because codes generated by hashids are equal when using differente salts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to demostrate an error with different salt generating the same code.
It generates the same code, no matter how many 'a' you append to the salt of the last hashids instance.
Expected behavior: codes should be different (every salt should generate a different code)
Note: Using short salt always generate different codes.