Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep "or-later" when relicensing #138

Closed
wants to merge 3 commits into from
Closed

Keep "or-later" when relicensing #138

wants to merge 3 commits into from

Conversation

hesa
Copy link
Contributor

@hesa hesa commented Nov 6, 2021

Some licenses have different compatbilities for "only" vs "or-later",
so we need to keep "or-later" and "only" when relicensing.

Some licenses have different compatbilities for "only" vs "or-later",
so we need to keep "or-later" and "only" when relicensing.
@hesa
Copy link
Contributor Author

hesa commented Nov 6, 2021

Example:
GPL-2.0-or-later <-------> GPL-3.0-or-later
GPL-2.0-only |-----| GPL-3.0-or-later

So relicensing GPL-2.0-or-later to GPL-2.0-only or GPL-3.0-only is not correct.
Should instead be GPL-2.0-or-later or GPL-3.0-or-later

Copy link
Collaborator

@priv-kweihmann priv-kweihmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the invalid lgpl > GPL Transition that LGTM

"GPL-2.0-only",
"LGPL-2.1-only",
"LGPL-3.0-only"
"GPL-2.0-or-later",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't look right to me - lgpl can't turn into GPL (no matter what version)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.gnu.org/licenses/old-licenses/lgpl-2.0.html

3. You may opt to apply the terms of the ordinary GNU General Public License instead of this License to a given copy of the Library. To do this, you must alter all the notices that refer to this License, so that they refer to the ordinary GNU General Public License, version 2, instead of to this License. (If a newer version than version 2 of the ordinary GNU General Public License has appeared, then you can specify that version instead if you wish.) Do not make any other change in these notices.

Once this change is made in a given copy, it is irreversible for that copy, so the ordinary GNU General Public License applies to all subsequent copies and derivative works made from that copy.

This option is useful when you wish to copy part of the code of the Library into a program that is not a library.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a lawyer, needless to say

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@silverhook any idea?

@priv-kweihmann
Copy link
Collaborator

priv-kweihmann commented Nov 7, 2021 via email

@hesa
Copy link
Contributor Author

hesa commented Nov 7, 2021

For me, I've always thought "latest lgpl" -> "latest gpl", which explains why I want to downgrade (LGPL 2.1 -> LGPL 2.0).

Your reasoning sounds legit as well.

@LeChasseur , do you have any insights in this? In short: LGPL states I can chose to take a LGPL (library) and make it GPL instead. Given a software licensed under "LGPLv2.1", can this be relicensed in to "GPLv2.0" and "GPLv3.0" or can it only be relicensed to "GPLv3.0"

@hesa
Copy link
Contributor Author

hesa commented Nov 7, 2021

@silverhook your input is welcome :)

@silverhook
Copy link

@hesa , see my comment in the review (mouse slipped, did not want to start a review)

@hesa
Copy link
Contributor Author

hesa commented Nov 8, 2021

@silverhook ... in the review? You know I am old and don't understand new and fancy stuff

@silverhook
Copy link

@hesa:

The same exists in LGPL-2.1, so I don’t see an issue here.

https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html

§3. You may opt to apply the terms of the ordinary GNU General Public License instead of this License to a given copy of the Library. To do this, you must alter all the notices that refer to this License, so that they refer to the ordinary GNU General Public License, version 2, instead of to this License. (If a newer version than version 2 of the ordinary GNU General Public License has appeared, then you can specify that version instead if you wish.) Do not make any other change in these notices.

Once this change is made in a given copy, it is irreversible for that copy, so the ordinary GNU General Public License applies to all subsequent copies and derivative works made from that copy.

This option is useful when you wish to copy part of the code of the Library into a program that is not a library.

@hesa
Copy link
Contributor Author

hesa commented Nov 9, 2021

@hesa:

The same exists in LGPL-2.1, so I don’t see an issue here.

@silverhook flict relicenses (trying to) for you. I know this is a border case and perhaps only a theoretical exercise. Still, want to get it right. If flict identifies a license it checks if it can relicense. So all possible relicensing is important to get down "on paper" correctly.

  • LGPL-2.0+ => GPL-2.0+ OR LGPL-2.1+: should be OK

  • LGPL-2.1 => GPL-2.0+ OR LGPL-2.1+: ? (see below)

Sorry for being pushy

below:

Possible interpretations:

  1. OK since we're talking version 2 in the licenses

  2. Not OK, since it will be a downgrade 2.1 to 2.0

@silverhook
Copy link

silverhook commented Nov 9, 2021

Personally, I’d say it’s 1) OK. It even explicitly says “GPL version 2”.

(Obviously you should talk to your lawyer, if you are in any doubts ;) )

@priv-kweihmann
Copy link
Collaborator

@hesa what are we going to do about this here?
After some thought I tend to agree with the originally proposed patch, as one can "upgrade" in terms of even stricter licensing when facing "LGPL-2.0+".
Can you rebase this one please?!

@hesa hesa closed this by deleting the head repository Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants