Skip to content

Steve Vinoski
vinoski

Organizations

@speakerconf
May 6, 2016
vinoski pushed to master at klacke/yaws
@vinoski
  • @vinoski bcdbd78
    Add Erlang/OTP 18.3 support in .travis.yml
May 5, 2016
vinoski pushed to master at klacke/yaws
@vinoski
May 5, 2016
vinoski merged pull request klacke/yaws#269
@vinoski
Don't crash on unknown query string in yaws_ls:parse_query/1
1 commit with 17 additions and 3 deletions
May 5, 2016
vinoski commented on pull request klacke/yaws#269
@vinoski

Is there a test for this?

Apr 29, 2016
vinoski closed pull request klacke/yaws#265
@vinoski
Improve yaws_ls:trim/3 to trim at UTF8 char boundary
Apr 29, 2016
vinoski commented on pull request klacke/yaws#265
@vinoski

I manually merged these changes to master. Thanks @leoliu !

Apr 29, 2016
vinoski pushed to master at klacke/yaws
@vinoski
  • @leoliu 1465a76
    Improve yaws_ls:trim/3 to trim at UTF8 char boundary
Apr 27, 2016
vinoski commented on pull request klacke/yaws#265
@vinoski

Maybe @capflam can have a look? I don't know enough about the details of unicode support in various Erlang versions to know what the problem might be.

Apr 27, 2016
vinoski commented on pull request klacke/yaws#265
@vinoski

@leoliu: it's easy to support multiple versions of Erlang on your system with kerl. With the latest update it looks like all versions older than R1…

Apr 26, 2016
vinoski commented on pull request klacke/yaws#265
@vinoski

This line makes anything older than Erlang 17 very unhappy in the Travis builds.

Apr 26, 2016
vinoski commented on pull request klacke/yaws#265
@vinoski

I would get rid of lines 1 and 2 here and replace them with %% -*- coding: latin-1 -*- (or whatever setting is appropriate).

Apr 26, 2016
vinoski pushed to master at vinoski/otp
@vinoski
Apr 25, 2016
vinoski commented on pull request klacke/yaws#265
@vinoski

It would be good to also have a test for this.

Apr 22, 2016
vinoski closed pull request klacke/yaws#263
@vinoski
Fix yaws_api:url_encode/1 to handle unicode chars
Apr 22, 2016
vinoski commented on pull request klacke/yaws#263
@vinoski

Conflicts resolved and fixes pushed. Thanks @leoliu !

Apr 22, 2016
vinoski pushed to master at klacke/yaws
@vinoski
  • @leoliu 8c0773f
    Fix yaws_api:url_encode/1 to handle unicode chars
Apr 22, 2016
vinoski commented on pull request klacke/yaws#263
@vinoski

OK, trying to fix the : and / encoding problem is way more involved than I thought, so I'm going to keep your behavior for them for now.

Apr 22, 2016
vinoski commented on pull request klacke/yaws#263
@vinoski

@leoliu: if : and / are not encoded, that's a bug. I'm taking your PR to a local branch and will amend your commit with a fix and test for this.

Apr 20, 2016
vinoski pushed to master at vinoski/otp
@vinoski
Apr 20, 2016
vinoski commented on issue klacke/yaws#264
@vinoski

Where did the A value come from? Was it created via json2 encoding?

Apr 17, 2016
vinoski commented on pull request klacke/yaws#263
@vinoski

Looks like all the Travis tests failed, so please investigate the failures and amend your commit with a fix. Also, are there any existing tests tha…

Apr 13, 2016
vinoski commented on issue klacke/yaws#262
@vinoski

@oubiwann: looking good! I suspect getting the tests to work will take some effort, since we never got them working fully with rebar.

Apr 13, 2016
vinoski commented on issue klacke/yaws#262
@vinoski

Great, thanks for doing this. Regarding Travis, we had a new commit in the past 12 hours and that build failed only on R16B03, but it passed just f…

Apr 9, 2016
vinoski commented on issue klacke/yaws#249
@vinoski

@oubiwann: I think dropping rebar and going with rebar3 is fine. I knew trying to support both would be a pain, and it's not really worth it especi…

Apr 9, 2016
vinoski commented on issue klacke/yaws#262
@vinoski

@oubiwann: regarding your note in #254 about make and assuming I understood it correctly: keep in mind that Yaws also provides a full automake-base…

Apr 9, 2016
vinoski commented on issue klacke/yaws#249
@vinoski

Oh, there's definitely a solution with rebar3, that doesn't worry me at all. It's simply a matter of someone finding the time to implement it.

Apr 9, 2016
vinoski commented on issue klacke/yaws#249
@vinoski

For rebar we had to use capabilities such as rebar.config.script and .app.src.script to be able to build Yaws successfully. (Interestingly, Yaws wo…

Apr 7, 2016
vinoski pushed to master at vinoski/otp
@vinoski
Apr 5, 2016
vinoski closed issue klacke/yaws#261
@vinoski
List of values in Module:crashmsg/3
Apr 5, 2016
vinoski commented on issue klacke/yaws#261
@vinoski

The issue is that in this context we're inside a crash handler. Something bad and unexpected has happened. There are things a normal out/1 function…

Something went wrong with that request. Please try again.