Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] --test flag should hide the UI in more cases #317

Closed
wavexx opened this issue Jun 24, 2021 · 4 comments
Closed

[BUG] --test flag should hide the UI in more cases #317

wavexx opened this issue Jun 24, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@wavexx
Copy link
Collaborator

wavexx commented Jun 24, 2021

Describe the bug
I had a few scripting scenarios where I just needed to communicate with the printer by serial, or to debug it. For this reason I didn't want any UI, so I tried to use "--test -s", but it still shows the LCD emulation.

Likewise, a similar scenario is "--test --gdb", where I might be scripting gdb and thus have no need for the UI as well.
Looks like the only scenario where --test hides the UI at the moment is "--test --script".

To Reproduce
Start with "--test -s" or "--test --gdb".

Expected behavior
No extra windows being shown in these scenarios.
I almost think --test should refuse to operate if not given a compatible option (--script, -s, --gdb, or something that gives the user a way to control the board without the lcd).

@wavexx wavexx added the bug Something isn't working label Jun 24, 2021
@vintagepc
Copy link
Owner

The "no graphics" part of that is probably wrong now as I believe in some cases we use --test with graphics for the automated testing components that take screenshots to verify the GL behaviour.

I think what you're looking for that is more suitable to your use case is also using -g none as an argument. That should suppress all graphics.

@wavexx
Copy link
Collaborator Author

wavexx commented Jun 24, 2021

Oh, well then, works good enough for me using --test in combination with -g none :)
Maybe it just needs a better description, or yeah removing the mention completely, so that graphics control is explicitly handled via -g.

@wavexx
Copy link
Collaborator Author

wavexx commented Jun 24, 2021

On the other side, is there an explicit way to request the "2D ui only" via -g? I know it's default, but I think it should be listed as an explicit choice.

@vintagepc
Copy link
Owner

Not currently but it should be possible to add one and just have it no-op

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants