Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comment): add 163gentie support #351

Merged
merged 1 commit into from May 16, 2017

Conversation

Projects
None yet
3 participants
@EYHN
Copy link
Contributor

commented May 15, 2017

Contributing rules

  • Fork the repo and create your branch from canary. Then be sure to put the canary branch as the target for your pull request.
  • Please be sure to follow the contributing guidelines, especially for commit message
  • Remove the Contributing rules part from this description
  • Fill out the other parts from this description

If you don't do so, we might change your pull request's title and using squash to merge your changed.

What kind of change does this PR introduce? (check one with "x")

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

Description

No description.


Verification steps

No verification steps.

@neoFelhz neoFelhz requested review from cubesky, viosey and neoFelhz May 15, 2017

<script>
var cloudTieConfig = {
url: document.location.href,
sourceId: "",

This comment has been minimized.

Copy link
@neoFelhz

neoFelhz May 15, 2017

Collaborator

Should we add id support for user, as the page.id is already exist.

This comment has been minimized.

Copy link
@neoFelhz

neoFelhz May 16, 2017

Collaborator

OK, I will add id support by myself.

@neoFelhz neoFelhz merged commit f941aed into viosey:canary May 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@neoFelhz neoFelhz referenced this pull request May 17, 2017

Closed

申请添加新的特性或功能 #352

1 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.