Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spidermon x Cerberus Documentation #6

Merged
merged 16 commits into from Aug 20, 2019

Conversation

@vipulgupta2048
Copy link
Owner

vipulgupta2048 commented Aug 5, 2019

馃悾

Regarding file changes,

  • I fixed some errors that sphinx was having building HTML, nothing big
  • Checkout, docs/source/getting-started.rst and docs/source/item-validation.rst
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@vipulgupta2048 vipulgupta2048 changed the title Docs cerberus Spidermon x Cerberus Documentation Aug 5, 2019
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Copy link
Collaborator

rennerocha left a comment

Add mention to Cerberus in line scrapinghub#20 of docs/source/item-validation.rst.

docs/source/item-validation.rst Outdated Show resolved Hide resolved
docs/source/item-validation.rst Show resolved Hide resolved
@ejulio
ejulio approved these changes Aug 13, 2019
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Copy link
Owner Author

vipulgupta2048 left a comment

Ready for takeoff! 馃殌
Let me know if there are any more changes required.

Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
docs/source/item-validation.rst Outdated Show resolved Hide resolved
@rennerocha rennerocha changed the base branch from master to cerberus Aug 20, 2019
Signed-off-by: Vipul Gupta (@vipulgupta2048) <vipulgupta2048@gmail.com>
@rennerocha rennerocha merged commit 6325f48 into cerberus Aug 20, 2019
@rennerocha rennerocha deleted the docs-cerberus branch Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.