New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProductARActivity is not needed #45

Closed
tiro105 opened this Issue Mar 12, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@tiro105

tiro105 commented Mar 12, 2018

https://github.com/viromedia/virocore/tree/master/ARRetail/app/src/main/java/com/example/virosample

Hi.
I would like to propose two modifications.

  • Delete ProductARActivity
  • Rename ProductARActivityComplete to ProductARActivity.

First, ProductARActivity does the same thing as ProductARActivityComplete (INTENT_PRODUCT_KEY also exists in ProductARActivityComplete).
Next, ProductARActivity's name is easily and simply than ProductARActivityComplete.

I fixed it, so please give me permission if necessary.

ViroCore is so cool. Thanks.

@dthian

This comment has been minimized.

Show comment
Hide comment
@dthian

dthian Mar 13, 2018

Contributor

Hi @tiro105, thanks for the suggestion, ProductARActivityComplete and ProductArActivity are actually both used in conjunction with the ARRetail tutorial.

Thus, to simplify the code base here, I've created a separate ARRetail project with starting sample code tailored to the tutorial, of which is then compressed and uploaded to the medium blog.

I've then removed ProduceARActivityComplete in favor of ProductARActivity and have made the changes to this git repo. Ideally, developers can then refer to this final activity should they get lost in the tutorial.

Theses changes should address your concerns and suggestions as mentioned above, do let me know if you have any questions.

Contributor

dthian commented Mar 13, 2018

Hi @tiro105, thanks for the suggestion, ProductARActivityComplete and ProductArActivity are actually both used in conjunction with the ARRetail tutorial.

Thus, to simplify the code base here, I've created a separate ARRetail project with starting sample code tailored to the tutorial, of which is then compressed and uploaded to the medium blog.

I've then removed ProduceARActivityComplete in favor of ProductARActivity and have made the changes to this git repo. Ideally, developers can then refer to this final activity should they get lost in the tutorial.

Theses changes should address your concerns and suggestions as mentioned above, do let me know if you have any questions.

@dthian dthian closed this Mar 13, 2018

@tiro105

This comment has been minimized.

Show comment
Hide comment
@tiro105

tiro105 Mar 13, 2018

@dthian Thank you!

ProductARActivityComplete remains in AndroidManifest.xml.
https://github.com/viromedia/virocore/blob/master/ARRetail/app/src/main/AndroidManifest.xml
If you do not need it, please delete it.

tiro105 commented Mar 13, 2018

@dthian Thank you!

ProductARActivityComplete remains in AndroidManifest.xml.
https://github.com/viromedia/virocore/blob/master/ARRetail/app/src/main/AndroidManifest.xml
If you do not need it, please delete it.

@dthian

This comment has been minimized.

Show comment
Hide comment
@dthian

dthian Mar 13, 2018

Contributor

Ah, was avoiding checking in the API Key and didn't commit those changes. It should be in now. Thanks again @tiro105!

Contributor

dthian commented Mar 13, 2018

Ah, was avoiding checking in the API Key and didn't commit those changes. It should be in now. Thanks again @tiro105!

@544531645 544531645 referenced this issue Jul 14, 2018

Closed

3d text #164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment