New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera button doesn't work #47

Closed
tiro105 opened this Issue Mar 13, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@tiro105

tiro105 commented Mar 13, 2018

Hi.

CameraButton doesn't work in ARRetail.
Error message in Logcat is below.

E/Viro: onTaskFailed NO_PERMISSIONS

Camera button does work when I set permission in settings.
Maybe, I think that ARRatail is caused by not setting Runtime permission about Storage.

Thanks.

Enviroment

- Pixel XL
- Android 8.1(API:27)
@dthian

This comment has been minimized.

Show comment
Hide comment
@dthian

dthian Mar 13, 2018

Contributor

Hi @tiro105, thanks for bringing this up. I've added a basic automatic permissions check in ARRetail as shown in the commit link below. This will prompt the user for a permissions check if none have yet been given: 875acde. Please keep in mind that this is mainly a basic proof of concept check. Let me know if you have any questions.

Contributor

dthian commented Mar 13, 2018

Hi @tiro105, thanks for bringing this up. I've added a basic automatic permissions check in ARRetail as shown in the commit link below. This will prompt the user for a permissions check if none have yet been given: 875acde. Please keep in mind that this is mainly a basic proof of concept check. Let me know if you have any questions.

@tiro105

This comment has been minimized.

Show comment
Hide comment
@tiro105

tiro105 Mar 13, 2018

Thanks, @dthian !

It worked perfectly.

I have a question, why do you use RECORD_AUDIO permission?
I thought that it is unnecessary because it is only taking pictures.

tiro105 commented Mar 13, 2018

Thanks, @dthian !

It worked perfectly.

I have a question, why do you use RECORD_AUDIO permission?
I thought that it is unnecessary because it is only taking pictures.

@dthian

This comment has been minimized.

Show comment
Hide comment
@dthian

dthian Mar 13, 2018

Contributor

Thanks @tiro105, you're right - that was mostly for video recording, but we are not doing that in this case. You should see them removed in the latest commit.

Contributor

dthian commented Mar 13, 2018

Thanks @tiro105, you're right - that was mostly for video recording, but we are not doing that in this case. You should see them removed in the latest commit.

@dthian dthian closed this Mar 13, 2018

@tiro105

This comment has been minimized.

Show comment
Hide comment
@tiro105

tiro105 Mar 14, 2018

@dthian Thanks a lot!

tiro105 commented Mar 14, 2018

@dthian Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment