Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: more snapshot sorting options: creation time, snapshot hierarchy #142

Open
bergentroll opened this issue Aug 23, 2020 · 1 comment
Open
Labels
blocked Needs work elsewhere before we can proceed (libvirt, qemu, design, discussion, etc) wishlist Nice to have but there's no current plans to implement

Comments

@bergentroll
Copy link

It is continue of https://bugzilla.redhat.com/show_bug.cgi?id=1859015. I am sorry for duplication, I have troubles with getting access to Bugzilla.

Briefly: snapshots on details window sorted now by name. Creation time seems more reasonable target to sort.

It seems it needs very small changes to do so: the sortname should include creationTime string instead of name. It takes beginning here:

sortname = "3%s" % name

Also concatenation of digit that is describing type of item with name is really laconic, but seems a bit fragile.

@crobinso
Copy link
Member

Thanks for the suggestion. I'm folding some other ideas into this as well, like an option to show the snapshot hierarchy as well, since the work will be in the same area. This was previously discussed at this older bug: https://bugzilla.redhat.com/show_bug.cgi?id=1065077

FWIW I doubt I will change anything here due to time constraints, until external snapshots are at a point that virt-manager can support them, at which point it will require a larger rethink of the UI which can include these improvements

@crobinso crobinso changed the title Snapshots sort order [Bug 1859015] RFE: more snapshot sorting options: creation time, snapshot hierarchy Sep 13, 2020
@crobinso crobinso added the blocked Needs work elsewhere before we can proceed (libvirt, qemu, design, discussion, etc) label Sep 15, 2020
@crobinso crobinso added the wishlist Nice to have but there's no current plans to implement label May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Needs work elsewhere before we can proceed (libvirt, qemu, design, discussion, etc) wishlist Nice to have but there's no current plans to implement
Projects
None yet
Development

No branches or pull requests

2 participants