New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undecorated window #233
Undecorated window #233
Conversation
bazsi
commented
Mar 10, 2021
This is in preparation for a more involved UI logic change where the size of the window needs to be decoupled from the "full-screen" mode of the console. Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
I have a 4k monitor and I have a VM that uses 1920x1080 resolution, which I would like to lay out in the top-right corner of my monitor. The problem is that as long as the window decoration, menubar and toolbar is visible, 1920x1080 does not fit in the 1/4th of my monitor. Also, the current virtual VGA driver for Windows does not support non-standard resolutions like VirtualBox, thus I am either seeing a lot of "black" space around my virtual desktop, or I would have to increase the size of my virt-manager window. None of this is appealing, so this patch implements a "windowed" full screen mode, which is basically an undecorated window, without a menu or toolbar. The same overlay is available at the top of the window than what is available in full screen. Signed-off-by: Balazs Scheidler <bazsi77@gmail.com>
|
This adds a feature described here: https://bugzilla.redhat.com/show_bug.cgi?id=1091311# |
|
Thanks for the patches but I'm sorry I don't think we should carry this in virt-manager. Per DESIGN.md I consider this Advanced Usage, and specifically it violates the section on Advanced VNC/SPICE usage, and there's already a reference there to previously rejecting undecorated windows. I will update that document with the menu bar example too. There may be other options though:
|
|
Hi @crobinso, I googled a little and found out that the Debian spice packages are called spice-vdagent and qemu-guest-agent. Any hints what I might be missing? |
|
@crobinso What a garbage decision. Who the heck cares about some rigid rules, the user comes first and foremost. Giving the user freedom to decide and use software how best fits them needs to be upheld and championed. |
|
@hockeymikey Stayin juuust a little more polite might have be the better option, don't you think? |
|
@JOJ0 No, I don't think so. |
|
@bazsi thanks for the PR! I was trying to make this work by building your fork, but couldn't see an Undecorated Window option in the menu. Could you please point me to how I could make this work? (Also since the time you wrote it, v4 of virt-manager is out and I suspect your commits can be integrated with minimal effort. I'd like to look at it, once I make it work for the earlier version) |
|
Well, it's been a long while since I submitted this. Checking out the source there should be a menu item in the top-level menu at right after "Fullscreen" that should toggle the new mode. To install it I didn't remember having to do too much things, I think I used "setup.py install" to a custom prefix and started from there. |