Netkvm guest announce #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Check" According to msdn: "If MiniportHaltEx causes a system error, then the miniport driver will see a nested call to MiniportShutdownEx with ShutdownActionNdisShutdownBugCheck. In this case, MiniportShutdownEx should return immediately without doing any work." Signed-off-by: Sameeh Jubran <sameeh@daynix.com>
This code was originally dropped in commit: 24d94e9 This code had a bug with parsing the ip addresses correctly due to alignment issue, however in this commit the issue was fixed. Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com> Signed-off-by: Sameeh Jubran <sameeh@daynix.com>
On control interrupt if the bit VIRTIO_NET_S_ANNOUNCE of status is set the driver should send gratuitous arp packet. In order to send the packet from the driver, it should have the IPV4 address/es that was assigned to it. The current implementation creates an Arp packet for each IPV4 that was assigned to the interface and it sends the packet upon receiving VIRTIO_NET_S_ANNOUNCE. Signed-off-by: Sameeh Jubran <sameeh@daynix.com>
This commit fixes the following errors: * Error LNK1295 '/INCREMENTAL' not compatible with '/KERNEL' specification; link without '/INCREMENTAL' * Error LNK2001 unresolved external symbol _RTC_Shutdown * Error LNK2019 unresolved external symbol __report_rangecheckfailure Signed-off-by: Sameeh Jubran <sameeh@daynix.com>
YanVugenfirer
approved these changes
Feb 19, 2017
|
Hi @YanVugenfirer , This is the first merge commit pushed to the repo since 2014 and there's only 13 of them total. I was wondering if we want to have a merge vs. rebase policy for virtio-win. I would personally lean towards always rebasing (i.e. no merge commits, the "Rebase and merge" option in GitHub UI) as I find it easier to work with linear history. That would also match what we've been doing until now when patches were manually applied to master/stable one-by-one. Thanks! |
|
Hi,
Actually I always insisted on the rebase and that's why we don't have merge
commits.
Unfortunately in this case I relied to much on github interface.
Not sure how to force the rebase if we want to use this useful "merge"
button :)
Best regards,
Yan.
…On Wed, Feb 22, 2017 at 4:43 PM, Ladi Prosek ***@***.***> wrote:
Hi @YanVugenfirer <https://github.com/YanVugenfirer> ,
This is the first merge commit pushed to the repo since 2014 and there's
only 13 of them total. I was wondering if we want to have a merge vs.
rebase policy for virtio-win.
I would personally lean towards always rebasing (i.e. no merge commits,
the "Rebase and merge" option in GitHub UI) as I find it easier to work
with linear history. That would also match what we've been doing until now
when patches were manually applied to master/stable one-by-one.
Thanks!
Ladi
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#102 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABDkWOxgubCdWUkWITob3S9-zIlUKf3Iks5rfEl6gaJpZM4MFdyW>
.
|
|
Sorry, totally my fault... I missed the "rebase and merge" option.
…On Wed, Feb 22, 2017 at 5:37 PM, Yan Vugenfirer ***@***.***> wrote:
Hi,
Actually I always insisted on the rebase and that's why we don't have
merge commits.
Unfortunately in this case I relied to much on github interface.
Not sure how to force the rebase if we want to use this useful "merge"
button :)
Best regards,
Yan.
On Wed, Feb 22, 2017 at 4:43 PM, Ladi Prosek ***@***.***>
wrote:
> Hi @YanVugenfirer <https://github.com/YanVugenfirer> ,
>
> This is the first merge commit pushed to the repo since 2014 and there's
> only 13 of them total. I was wondering if we want to have a merge vs.
> rebase policy for virtio-win.
>
> I would personally lean towards always rebasing (i.e. no merge commits,
> the "Rebase and merge" option in GitHub UI) as I find it easier to work
> with linear history. That would also match what we've been doing until now
> when patches were manually applied to master/stable one-by-one.
>
> Thanks!
> Ladi
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#102 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ABDkWOxgubCdWUkWITob3S9-zIlUKf3Iks5rfEl6gaJpZM4MFdyW>
> .
>
--
-----------------------------------------------------------------------
Daynix Computing LTD
Yan Vugenfirer, CEO
Email: yan@daynix.com
Phone (Israel): +972-54-4758084
Phone (USA): +1-7204776716
Phone (UK): +44-2070482938
Web: www.daynix.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.