NetKVM: BZ#1537430 Import LinkSpeed/Duplex configs from the hypervisor #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YanVugenfirer
approved these changes
Jan 24, 2018
YanVugenfirer
requested changes
Jan 24, 2018
Changes following the introduction of virtio's flag, VIRTIO_NET_F_SPEED_DUPLEX,
which allows the host to set the LinkSpeed/Duplex values.
Up until this stage the configurations of LinkSpeed/Duplex used were hardcoded,
with default LinkSpeed=10Gbits/s, Duplex=full.
But uppon the introduction of VIRTIO_NET_F_SPEED_DUPLEX, it'll be more useful to
import them from the host and apply them if the VIRTIO_NET_F_SPEED_DUPLEX is on,
or, use the default configurations if it is off:
(LinkSpeed=10Gbits/s, Duplex=full).
Changes also includes removing the ConnectRate parameter from the inf file as we
never saw that it was used.
Qemu patches:
1. [v4,2/3] qemu: virtio-net: use 64-bit values for feature flags:
https://patchwork.ozlabs.org/patch/856266/
2. [v4,3/3] qemu: add linkspeed and duplex settings to virtio-net:
https://patchwork.ozlabs.org/patch/856226/
Signed-off-by: Bishara AbuHattoum <bishara@daynix.com>
YanVugenfirer
approved these changes
Jan 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes following the introduction of virtio's flag, VIRTIO_NET_F_SPEED_DUPLEX,
which allows the host to set the LinkSpeed/Duplex values.
Up until this stage the configurations of LinkSpeed/Duplex used were hardcoded,
with default LinkSpeed=10Gbits/s, Duplex=full.
But uppon the introduction of VIRTIO_NET_F_SPEED_DUPLEX, it'll be more useful to
import them from the host and apply them if the VIRTIO_NET_F_SPEED_DUPLEX is on,
or, use the default configurations if it is off:
(LinkSpeed=10Gbits/s, Duplex=full).
Changes also includes removing the ConnectRate parameter from the inf file as we
never saw that it was used.
Qemu patches:
https://patchwork.ozlabs.org/patch/856266/
https://patchwork.ozlabs.org/patch/856226/
Signed-off-by: Bishara AbuHattoum bishara@daynix.com