Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sriov fixes and diagnostics #515

Merged
merged 7 commits into from Nov 2, 2020
Merged

Sriov fixes and diagnostics #515

merged 7 commits into from Nov 2, 2020

Conversation

ybendito
Copy link
Collaborator

No description provided.

Check for source handle is sufficient to recognize internal
(announcement) packets. Check for single NBL in the chain
does not work in case of SRIOV bonding, as several such packets
can be completed by SRIOV adapter in a chain. Each NBL still
must be later isolated and passed to the completion procedure.

Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
https://bugzilla.redhat.com/show_bug.cgi?id=1830754
We need to filter out all the internal (announcement) packets
from the NBL chain returned by SRIOV adapter. We use
NBL->MiniportReserved[0] to hold the object to deallocate.
This is OK until we pass the packet to another adapter that
can override this field. So we maintain the list of all the
internal NBLs with their original MiniportReserved before
we pass them to SRIOV. On completion we recognize internal
NBLs and restore MiniportReserved field and then pass them to
the owner (CGuestAnnouncePackets).

Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
Copy link
Collaborator

@YanVugenfirer YanVugenfirer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CI.

@ybendito
Copy link
Collaborator Author

ybendito commented Nov 1, 2020

rerun tests

@YanVugenfirer YanVugenfirer merged commit 4a3db60 into master Nov 2, 2020
@ybendito ybendito deleted the sriov-fix branch February 12, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants