RHBZ#2075862: VirtIO-FS: make the service stoppable #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T_SHUTDOWN Now service can be stopped by Service Manager, because it handles SERVICE_CONTROL_STOP and SERVICE_CONTROL_SHUTDOWN. Signed-off-by: Viktor Prutyanov <viktor@daynix.com>
Signed-off-by: Viktor Prutyanov <viktor@daynix.com>
…ce remove FUSE session should be started with FUSE_INIT and ended with FUSE_DESTROY. It resets host state, including unreferencing all inodes. Signed-off-by: Viktor Prutyanov <viktor@daynix.com>
…FileSystem FileSystem in Stop() may be deleted already if the device is removed. Signed-off-by: Viktor Prutyanov <viktor@daynix.com>
viktor-prutyanov
force-pushed
the
viofs-stop
branch
from
60f8890
to
018dcf7
Compare
|
@viktor-prutyanov HCK-CI is currently disabled. I will try to enable it ASAP. |
@kostyanf14 I think we aren't going to merge this PR until Monday. Moreover, there are no driver changes here, so for this PR no WHQL is needed, only build. |
YanVugenfirer
approved these changes
Apr 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now service can be stopped by Service Manager, because it handles
SERVICE_CONTROL_STOPandSERVICE_CONTROL_SHUTDOWN.Besides of that, the service submits
FUSE_DESTROYrequest to end FUSE session at service stop and device remove.