RHBZ#2112559: VirtIO-FS: align group rights to owner rights #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In e3e722c both owner and group on guest side were set to Everyone. But when converting POSIX mode to Windows security descriptor WinFSP can restrict owner's rights to group's rights if owner's rights are more permissive. Thereby, some previosly working configurations (e.g. shared directory with 0700 rights) were broken. So, evelate group rights when converting to security descriptor. Signed-off-by: Viktor Prutyanov <viktor@daynix.com>
YanVugenfirer
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
e3e722cboth owner and group on guest side were set toEveryone. But when converting POSIX mode to Windows security descriptor WinFSP can restrict owner's rights to group's rights if owner's rights are more permissive. Thereby, some previosly working configurations (e.g. shared directory with0700rights) were broken. So, evelate group rights when converting to security descriptor.