RHBZ#2177673: fwcfg64: don't fail if unable to work with vmcoreinfo #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, fwcfg64 driver used to fail if fw_cfg was present, but 'etc/vmcoreinfo' entry wasn't. The driver shouldn't fail when device is OK. Anyway, 'dump-guest-memory -w' will not work without vmcoreinfo. Signed-off-by: Viktor Prutyanov <viktor@daynix.com>
viktor-prutyanov
force-pushed
the
fwcfg64-dont-fail
branch
from
2bcb215
to
5847cde
Compare
viktor-prutyanov
changed the title
|
rerun tests |
YanVugenfirer
approved these changes
Mar 13, 2023
|
rerun tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, fwcfg64 driver was failing if fw_cfg device was present, but
etc/vmcoreinfoentry wasn't. The driver shouldn't fail when device is OK. Anyway,dump-guest-memory -wwill not work without vmcoreinfo.