Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions made to samples user guide #58

Merged
merged 5 commits into from Feb 14, 2020
Merged

Conversation

@mdhaul
Copy link
Contributor

mdhaul commented Feb 12, 2020

  • resolves #57
  • setting screenshots updated
  • delete/edit a sample added
  • info on caching included at the top (should this section be somewhere else on the page?)
  • default subtraction added as a subsection at the end of "create a sample" section
  • quality analysis information added with interpretation
@igboyes igboyes self-requested a review Feb 12, 2020
Copy link
Member

igboyes left a comment

I'll talk to you about this.

content/docs/manual/ug_samples/index.md Show resolved Hide resolved
content/docs/manual/ug_samples/index.md Show resolved Hide resolved
content/docs/manual/ug_samples/index.md Show resolved Hide resolved
content/docs/manual/ug_samples/index.md Outdated Show resolved Hide resolved
content/docs/manual/ug_samples/index.md Outdated Show resolved Hide resolved
@mdhaul

This comment has been minimized.

Copy link
Contributor Author

mdhaul commented Feb 13, 2020

Ok so I think I've made all the changes we talked about. I've put the comparison for sample vs cache quality under "Trim Caches". There is also a separate section called "Sample Quality" under "Create Sample" that also talks about the samples quality. Is that too repetitive? The "Sample Quality" section does not include cache quality because I've added that under "Trim Catches".

Let me know your thoughts.

mdhaul and others added 2 commits Feb 13, 2020
@igboyes igboyes changed the title Additions made to Samples-User-Guide Additions made to samples user guide Feb 14, 2020
@igboyes igboyes merged commit 1752596 into virtool:master Feb 14, 2020
5 checks passed
5 checks passed
Header rules No header rules processed
Details
Pages changed 2 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.