Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels collection and endpoints #1892

Merged
merged 10 commits into from Sep 25, 2020
Merged

Conversation

tianshengsui
Copy link
Contributor

resolved #1888

@igboyes igboyes self-requested a review September 24, 2020 23:38
Copy link
Member

@igboyes igboyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great attention to detail. Thanks. Just a few things to improve and fix.

virtool/dispatcher.py Outdated Show resolved Hide resolved
virtool/labels/api.py Outdated Show resolved Hide resolved
virtool/labels/api.py Outdated Show resolved Hide resolved
virtool/labels/api.py Outdated Show resolved Hide resolved
virtool/routes.py Outdated Show resolved Hide resolved
virtool/labels/api.py Outdated Show resolved Hide resolved
virtool/labels/api.py Outdated Show resolved Hide resolved
virtool/labels/api.py Outdated Show resolved Hide resolved
virtool/labels/api.py Outdated Show resolved Hide resolved
virtool/labels/checks.py Outdated Show resolved Hide resolved
Copy link
Member

@igboyes igboyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@igboyes igboyes merged commit 6908cf6 into virtool:cloud Sep 25, 2020
@tianshengsui tianshengsui deleted the labels branch September 25, 2020 21:13
@tianshengsui tianshengsui restored the labels branch September 25, 2020 21:20
@tianshengsui tianshengsui deleted the labels branch September 25, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants