Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements parametric rim lighting #3

Closed
il-m-yamagishi opened this issue May 8, 2019 · 1 comment · Fixed by #10
Closed

Implements parametric rim lighting #3

il-m-yamagishi opened this issue May 8, 2019 · 1 comment · Fixed by #10
Labels
enhancement New feature or request released

Comments

@il-m-yamagishi
Copy link
Contributor

https://github.com/Santarh/MToon/blob/master/MToon/Resources/Shaders/MToonCore.cginc#L180

    half3 rim = pow(saturate(1.0 - dot(worldNormal, worldView) + _RimLift), _RimFresnelPower) * _RimColor.rgb * tex2D(_RimTexture, mainUv).rgb;
    rim *= lerp(half3(1, 1, 1), pureLight, _RimLightingMix);
    col += lerp(rim, half3(0, 0, 0), i.isOutline);
@il-m-yamagishi il-m-yamagishi added the enhancement New feature or request label May 8, 2019
@il-m-yamagishi il-m-yamagishi changed the title Implement parametric rim lighting Implements parametric rim lighting May 8, 2019
il-m-yamagishi added a commit that referenced this issue May 17, 2019
@il-m-yamagishi
feat(Rim): Implements parametric rim lighting
722fd55 
fix #3
@il-m-yamagishi il-m-yamagishi mentioned this issue May 17, 2019
Merged
il-m-yamagishi pushed a commit that referenced this issue May 17, 2019
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
f8a36b9 
# [1.3.0](v1.2.0...v1.3.0) (2019-05-17)

### Features

* **Rim:** Implements parametric rim lighting ([722fd55](722fd55)), closes [#3](#3)
@il-m-yamagishi
Copy link
Contributor Author

🎉 This issue has been resolved in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@il-m-yamagishi il-m-yamagishi mentioned this issue May 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Rim): Implements parametric rim lighting virtual-cast/babylon-mtoon-material
1 participant
@il-m-yamagishi