Skip to content

Conversation

@everthemore
Copy link
Member

No description provided.

@everthemore everthemore requested a review from akhmerov January 29, 2021 12:14
@everthemore everthemore linked an issue Jan 29, 2021 that may be closed by this pull request

# If a paper link is available, add it. Not all talks have preprints
if( talk.get('preprint', '') != '' ):
talk_payload["paper_link"] = "https://arxiv.org/abs/"+talk.get('preprint')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had an example of somebody using a DOI and a different repository, so this may produce nonsense.

I suggest using something like this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I thought those would have been filtered before getting to this point. I was wrong.
I assume you mean that we

  • use the arxiv link if talk['preprint'] is an arxiv identifier,
  • use talk['preprint'] as long as it is a valid URL,
  • otherwise add this as a talk comment?

The researchseminars API will fail if this entry is not a proper URL, and we can't guarantee that for talk['preprint'], right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could regex-match a DOI, however I propose that we specifically regex match an arxiv preprint, and ignore anything else.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed 👍

@akhmerov
Copy link
Member

One last remark about the preprint format. The rest looks good 👍

@akhmerov
Copy link
Member

There may be a complication with LRC because we frequently edit those at a later stage. However right now we'd also create the events as TBA, so I propose to keep track of updating data in research seminars as a follow-up action.

@everthemore
Copy link
Member Author

There may be a complication with LRC because we frequently edit those at a later stage. However right now we'd also create the events as TBA, so I propose to keep track of updating data in research seminars as a follow-up action.

When adding a talk to researchseminars, it gets assigned a number (just the total talk number as a counter), that we would have to keep track of for editing it. We would have to add it to the yaml most likely, or otherwise search the talk list for a match (based on title,author,preprint?).

@akhmerov
Copy link
Member

When adding a talk to researchseminars, it gets assigned a number (just the total talk number as a counter), that we would have to keep track of for editing it.

We can also do extra queries (first get all talks, then edit). But let's defer the implementation of that step.

@everthemore everthemore merged commit 7878db7 into master Jan 30, 2021
@everthemore everthemore deleted the researchseminarsdotorg branch July 9, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

publishing new events at researchseminars

3 participants