Define _POSIX_C_SOURCE to expose popen/pclose #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems the Mac OS X libc is broken. |
popen and pclose aren't exposed by musl libc unless one of the following
macros is defined:
#if defined(_POSIX_SOURCE) || defined(_POSIX_C_SOURCE) \
|| defined(_X_OPEN_SOURCE) || defined(_GNU_SOURCE) \
|| defined(_BSD_SOURCE)
According to popen(3) on Linux man-pages 6.05.01:
Feature Test Macro Requirements for glibc (...):
popen(), pclose():
_POSIX_C_SOURCE >= 2
|| /* glibc <= 2.19: */ _BSD_SOURCE || _SVID_SOURCE
Notes:
* _POSIX_SOURCE has been superseded by _POSIX_C_SOURCE.
* _POSIX_C_SOURCE with a value of 2 (POSIX.2-1992) is the option that
potentially causes the least namespace contamination.
* Seems the Mac OS X libc is broken: it hides snprintf/vsnprintf with
_POSIX_C_SOURCE == 2, which is presumably wrong.
See feature_test_macros(7) for more information about the macros.
|
Yea. I do find strange things on OSX sometimes. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On musl libc
popenandpclosearen't exposed by musl libc unless one of the following macros is defined:On Glibc
According to manpage
popen(3)on Linux man-pages6.05.01:Notes
_POSIX_SOURCEhas been superseded by_POSIX_C_SOURCE._POSIX_C_SOURCEwith a value of 2 is the option that potentially causes the least namespace contamination.See
feature_test_macros(7)for more information about the macros.