Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime safety - No checks whether message type extends custom trait associated with our serializer #8

Closed
MarconZet opened this issue Apr 19, 2021 · 3 comments
Closed

Runtime safety - No checks whether message type extends custom trait associated with our serializer #8

MarconZet opened this issue Apr 19, 2021 · 3 comments
Labels
duplicate This issue or pull request already exists soundness Relates to guaranteeing run-time safety at compile-time

Comments

@MarconZet
Copy link
Collaborator

Akka determines what serialiser to use on what message based on the class of the message and its supertype. If a supertype is declared incorrectly, unexpected behaviour may occur.
@PawelLipski PawelLipski changed the title Runtime safety - No checks wheater message type extends custom trait associated with our serialiser Runtime safety - No checks whether message type extends custom trait associated with our serializer Apr 24, 2021
@PawelLipski
Copy link
Collaborator

Hmmm could you provide a minimal repro? Esp. what you mean by supertype is declared incorrectly

@PawelLipski PawelLipski added soundness Relates to guaranteeing run-time safety at compile-time labels Apr 27, 2021
@PawelLipski
Copy link
Collaborator

(@MarconZet bump)

@PawelLipski PawelLipski added the duplicate This issue or pull request already exists label May 4, 2021
@PawelLipski
Copy link
Collaborator

Duplicate of #5

@PawelLipski PawelLipski marked this as a duplicate of #5 May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists soundness Relates to guaranteeing run-time safety at compile-time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PawelLipski @MarconZet