Skip to content

Use CanvasContext setter for device pixels #9870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use CanvasContext setter for device pixels #9870

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49eae1a
Use CanvasContext setter for device pixels
ibgreen Nov 17, 2025
6398324
Merge branch 'master' into codex/replace-manual-_handleresize-with-ca…
chrisgervang Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 2 additions & 17 deletions modules/core/src/lib/deck.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,23 +485,8 @@ export default class Deck<ViewsT extends ViewOrViews = null> {
// Update the animation loop
this.animationLoop?.setProps(resolvedProps);

if (
props.useDevicePixels !== undefined &&
this.device?.canvasContext?.canvas instanceof HTMLCanvasElement
) {
// TODO: It would be much cleaner if CanvasContext had a setProps method
this.device.canvasContext.props.useDevicePixels = props.useDevicePixels;
const canvas = this.device.canvasContext.canvas;
const entry = {
target: canvas,
contentBoxSize: [{inlineSize: canvas.clientWidth, blockSize: canvas.clientHeight}],
devicePixelContentBoxSize: [
{inlineSize: canvas.clientWidth, blockSize: canvas.clientHeight}
],
borderBoxSize: [{inlineSize: canvas.clientWidth, blockSize: canvas.clientHeight}]
};
// Access the protected _handleResize method through the canvas context
(this.device.canvasContext as any)._handleResize([entry]);
if (props.useDevicePixels !== undefined && this.device?.canvasContext) {
this.device.canvasContext.setProps({useDevicePixels: props.useDevicePixels});
}

// If initialized, update sub manager props
Expand Down
Loading