Allow user to change encoder during runtime #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chrisgervang
commented
May 31, 2020
•
chrisgervang
commented
- Remove redundant HubbleGl class
- Encoders are constructed right before rendering starts now, removing them from adapter construction procedure.
- VideoCapture is now constructed in adapter constructor.
- Removed deckgl specific variables from VideoCapture so it is now a generic canvas capture tool.
- Refactored encoder settings to be namespaced by encoder
- DeckAdapter.render and VideoCapture.render now accepts a onStop callback
chrisgervang
force-pushed
the
fix-set-encoder
branch
2 times, most recently
from
7e86ec3
to
aeb971a
Compare
chrisgervang
changed the title
- Remove redundant HubbleGl class - Encoders are constructed right before rendering starts now, removing them from adapter construction procedure. - VideoCapture is now constructed in adapter constructor. - Removed deckgl specific variables from VideoCapture so it is now a generic canvas capture tool. - Refactored encoder settings to be namespaced by encoder - DeckAdapter.render and VideoCapture.render now accepts a onStop callback
This reverts commit 8757e38.
chrisgervang
force-pushed
the
fix-set-encoder
branch
from
c1e98a3
to
a528fb7
Compare
chrisgervang
pushed a commit
that referenced
this pull request
Sep 11, 2020
…or all examples in the hubble folder | Changes applied from review #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.