[refactor] Make scene definition synchronous by supplying our own Timeline #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgervang
commented
Jun 15, 2021
| @@ -71,16 +72,15 @@ export default function App() { | |||
| }); | |||
| }, [viewStateA, viewStateB]); | |||
|
|
|||
| const getDeckScene = timeline => { | |||
There was a problem hiding this comment.
Previously users had to provide a callback so that deck could supply the timeline. It's confusing and not necessary.
Pull Request Test Coverage Report for Build 941589418
💛 - Coveralls |
chrisgervang
commented
Jun 15, 2021
| @@ -103,7 +103,7 @@ export default function App() { | |||
| }} | |||
| controller={true} | |||
| effects={[vignetteEffect, aaEffect]} | |||
| {...adapter.getProps({deckRef, setReady, onNextFrame, getLayers})} | |||
There was a problem hiding this comment.
We get to remove React Ref from hubble's interface, which helps #22 eventually happen.
chrisgervang
commented
Jun 15, 2021
| constructor(sceneBuilder, glContext = undefined) { | ||
| this.sceneBuilder = sceneBuilder; | ||
| constructor(scene, glContext = undefined) { | ||
| this.scene = scene; |
There was a problem hiding this comment.
Scene is now always defined, so the undefined behavior branches can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new DeckAdapter({sceneBuilder})removed, replaced by synchronoussceneobject parameter.DeckAdapter.render({setReady})is now optional since deck will only be referenced when recording.DeckAdapterimplementation.