Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] remove width and height from DeckScene #119

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

chrisgervang
Copy link
Collaborator

Remove width and height from DeckScene so that the class is only focused on managing animation state. Instead provide DeckGl with width and height prop directly to control its render resolution. Note mapbox still determines its dimension by filling whatever container it is put in, so deck and mapbox should be set to the same value if used together.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 944925150

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 22.346%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/core/src/adapters/deck-adapter.js 0 1 0.0%
Totals Coverage Status
Change from base Build 944639625: 0.0%
Covered Lines: 139
Relevant Lines: 531

💛 - Coveralls

@chrisgervang chrisgervang merged commit 3f303ea into master Jun 17, 2021
@chrisgervang chrisgervang deleted the chr/monitor-panel branch June 28, 2021 19:29
@chrisgervang chrisgervang added this to the 1.3 milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants