Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] new keyframe classes #125

Merged
merged 6 commits into from
Jun 28, 2021
Merged

[enhancement] new keyframe classes #125

merged 6 commits into from
Jun 28, 2021

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Jun 28, 2021

Adding support for many new keyframe types.

Added

  • set method added to Keyframes class so that animations updates do not need to be reregistered to a Timeline.
  • DeckLayerKeyframes, useful for animating any deck.gl layer. Specify layer props as keyframe keys (such as getRadius).
  • KeplerFilterKeyframes, supports all filter types in kepler.gl and will autogenerate keyframes for all timeRange filter types.
  • KeplerLayerKeyframes, useful for animating any kepler.gl layer vis config.
  • KeplerTripKeyframes, autogenerates keyframes given an animationConfig.

Removed

  • LayerKeyframes, use DeckLayerKeyframes
  • GridLayerKeyframes, use DeckLayerKeyframes
  • ScatterPlotLayerKeyframes, use DeckLayerKeyframes
  • FilterValueKeyframes, use KeplerFilterKeyframes instead.

Todo

  • docs
  • tests

@coveralls
Copy link

coveralls commented Jun 28, 2021

Pull Request Test Coverage Report for Build 980259513

  • 11 of 71 (15.49%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-2.6%) to 19.382%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/core/src/keyframes/deck-layer-keyframes.js 0 3 0.0%
modules/core/src/keyframes/kepler-layer-keyframes.js 0 5 0.0%
modules/core/src/keyframes/kepler-trip-keyframes.js 0 8 0.0%
modules/core/src/keyframes/kepler-filter-keyframes.js 0 44 0.0%
Files with Coverage Reduction New Missed Lines %
modules/core/src/keyframes/keyframes.js 1 60.0%
Totals Coverage Status
Change from base Build 980187630: -2.6%
Covered Lines: 142
Relevant Lines: 594

💛 - Coveralls

@chrisgervang chrisgervang merged commit da3737a into master Jun 28, 2021
@chrisgervang chrisgervang deleted the chr/new-keyframes branch June 28, 2021 23:45
@chrisgervang chrisgervang added this to the 1.3 milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants