Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] Replace DeckScene with AnimationManager #130

Merged
merged 9 commits into from
Jun 29, 2021

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Jun 29, 2021

This is a large internal refactor of animation wirings.

Added

  • AnimationManager, introduce a draw function to render each frame.
  • useDeckAdapter hook, for easy react integration.
  • Mutable keyframes using adapter.animationManager.setKeyframes
  • Support for any number of simultaneous animations using.
  • adapter.seek now draws when called.

Refactor

  • worldview's kepler support is less redux-dependent, and is now handled by KeplerAnimation.

Removed

  • DeckScene removed, use AnimationManager instead (its library agnostic).
  • getCameraKeyframes and getLayerKeyframes removed throughout, now handled by DeckAnimation.
    • removed from adapter.render, adapter.seek, deck scene functions, BasicControls, QuickAnimation

Todo

  • api docs
  • example docs

@coveralls
Copy link

coveralls commented Jun 29, 2021

Pull Request Test Coverage Report for Build 983325756

  • 0 of 14 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 16.701%

Changes Missing Coverage Covered Lines Changed/Added Lines %
modules/core/src/adapters/deck-adapter.js 0 6 0.0%
modules/core/src/animations/animation-manager.js 0 8 0.0%
Totals Coverage Status
Change from base Build 983311668: 0.9%
Covered Lines: 142
Relevant Lines: 667

💛 - Coveralls

@chrisgervang chrisgervang merged commit 2e6c89e into master Jun 29, 2021
@chrisgervang chrisgervang deleted the chr/animation-manager branch October 14, 2021 19:46
@chrisgervang chrisgervang added this to the 1.3 milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants