Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kepler) blank layer when no deck layers #163

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Sep 17, 2021

For #157.

Test

  • Open kepler-integration example, delete all layers, attempt to export video.
  • Also should work when all layers are just "unseen"

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1247366727

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 26.641%

Totals Coverage Status
Change from base Build 1247350731: 0.0%
Covered Lines: 217
Relevant Lines: 708

💛 - Coveralls

Copy link
Collaborator

@igorDykhta igorDykhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@chrisgervang chrisgervang merged commit f092344 into master Sep 20, 2021
@chrisgervang chrisgervang deleted the chr/kepler-blank-layer branch September 20, 2021 20:25
@chrisgervang chrisgervang added this to the 1.3 milestone Oct 15, 2021
@coveralls
Copy link

coveralls commented Nov 5, 2024

Pull Request Test Coverage Report for Build 1247366727

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 26.641%

Totals Coverage Status
Change from base Build 1247350731: 0.0%
Covered Lines: 217
Relevant Lines: 708

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants