Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kepler export) match 3d perspective in video export #177

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Oct 7, 2021

Video export 3d mode appeared broken when pitch/bearing aren't preserved. This is a workaround since we WebMercatorViewport doesn't have a fitPerspectiveBounds.

Before

kepler-before-3d-loss.mov

After

kepler-after-match-3d.mov

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1317954820

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 26.511%

Totals Coverage Status
Change from base Build 1317894042: 0.0%
Covered Lines: 217
Relevant Lines: 709

💛 - Coveralls

@chrisgervang chrisgervang merged commit 6472c34 into master Oct 7, 2021
@chrisgervang chrisgervang deleted the chr/kepler-viewstate-3d branch October 14, 2021 19:44
@chrisgervang chrisgervang added this to the 1.3 milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants