Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(kepler) default filename prop #182

Merged
merged 1 commit into from
Oct 12, 2021
Merged

add(kepler) default filename prop #182

merged 1 commit into from
Oct 12, 2021

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Oct 11, 2021 •
edited
Loading

Changelog
Set default filename prop to set input placeholder and default filename.

<ExportVideoPanelContainer
  ...
  defaultFileName={'hubble.gl'}
/>

Screen Shot 2021-10-11 at 4 56 40 PM
Screen Shot 2021-10-11 at 4 56 44 PM
Screen Shot 2021-10-11 at 4 56 49 PM

@chrisgervang
add(kepler) default filename prop
ff9e532 
- set default filename prop to set input placeholder and default filename
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1331009105

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 26.511%
Totals Coverage Status
Change from base Build 1318050447: 0.0%
Covered Lines: 217
Relevant Lines: 709
💛 - Coveralls

@chrisgervang chrisgervang merged commit a1558cd into master Oct 12, 2021
@chrisgervang chrisgervang deleted the chr/filename-placeholder branch October 14, 2021 19:44
@chrisgervang chrisgervang added this to the 1.3 milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heshan0131 heshan0131 heshan0131 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisgervang @coveralls @heshan0131