Skip to content

add(kepler) stop button and disable settings when previewing or rendering #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Oct 12, 2021

  • add(kepler) stop button for both preview and partial render

  • add(kepler) disable settings when previewing or rendering

  • Properly disable from kepler.gl

kepler-disable.mov

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1331129866

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 26.511%

Totals Coverage Status
Change from base Build 1318050447: 0.0%
Covered Lines: 217
Relevant Lines: 709

💛 - Coveralls

@chrisgervang chrisgervang added this to the 1.3 milestone Oct 15, 2021
@chrisgervang
Copy link
Collaborator Author

@heshan0131 @macrigiuseppe I'm going to merge this in, but one outstanding item remains. I'm not sure how to disable a <Slider/> from kepler.gl. Is that possible?

@chrisgervang chrisgervang merged commit a2ff8a8 into master Oct 15, 2021
@chrisgervang chrisgervang deleted the chr/kepler-polish branch October 15, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants