Renable PNGEncoder blank (transparent) frames #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaymondDashWu
added a commit
to RaymondDashWu/hubble.gl
that referenced
this pull request
Aug 5, 2020
chrisgervang
pushed a commit
that referenced
this pull request
Sep 12, 2020
* [FIX/ADD] Fixed missing steps to instructions + added extra notation * [FIX] Forgot missing step in #8 * [FIX/ADD] Fix step 9 and added clarification * [DEL] Extraneous folders/files * [TEST] Is this how you link markdown images? * [ADD] Rendering tips/guide * [FIX] Separated GIF/MP4 so it can't be interpreted together * [FIX] Made steps more clear by bolding and fixed sequence conversion to gif not mp4 * [FIX?] Image not loading * [FIX] MP4 => GIF error * [FIX] Spacing between Step #s * [FIX] Step #4 spacing * [FIX/ADD] Removed MP4 from docs + added entry to table of contents * [MOVE] Images move to website static folder + location updated * [FIX] Image URLS
RaymondDashWu
added a commit
to RaymondDashWu/hubble.gl
that referenced
this pull request
Nov 3, 2020
* Upgrade packages, downgrade node (for now) (visgl#14) Pinning node to version 12.6.3 per discussion. Upgrading to deck 8.2.2 * Improve App Integration: Make Camera and Layers Optional in a DeckScene (visgl#15) * Minor keyframe class clean up, removing unused defaults * Camera and Layers are optional in a DeckScene - Animating the camera is optional, but if a keyframe is defined then viewState is controlled by camera keyframe. - To Use: do not provide a `camera` to `keyframes` parameter when constructing DeckScene. - Animating layers is optional, only replace layers prop when scene provides layers. - To Use: do not provide a `renderLayers` parameter when constructing DeckScene * Adding Camera Example to docs * [FIX/ADD] Fixed missing steps to instructions + added extra notation (visgl#13) * [FIX/ADD] Fixed missing steps to instructions + added extra notation * [FIX] Forgot missing step in visgl#8 * [FIX/ADD] Fix step 9 and added clarification * [DEL] Extraneous folders/files * Adding a ResolutionGuide component to examples...(visgl#17) ...so the background doesn't look so empty. * v1.1.0-alpha.3 (visgl#18) * v1.1.0-alpha.4 * Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> * Bump elliptic from 6.5.2 to 6.5.3 Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com> * lint (visgl#28) * v1.1.0-alpha.5 * Documentation fixes additions (visgl#21) * [FIX/ADD] Fixed missing steps to instructions + added extra notation * [FIX] Forgot missing step in visgl#8 * [FIX/ADD] Fix step 9 and added clarification * [DEL] Extraneous folders/files * [TEST] Is this how you link markdown images? * [ADD] Rendering tips/guide * [FIX] Separated GIF/MP4 so it can't be interpreted together * [FIX] Made steps more clear by bolding and fixed sequence conversion to gif not mp4 * [FIX?] Image not loading * [FIX] MP4 => GIF error * [FIX] Spacing between Step #s * [FIX] Step visgl#4 spacing * [FIX/ADD] Removed MP4 from docs + added entry to table of contents * [MOVE] Images move to website static folder + location updated * [FIX] Image URLS * Bump http-proxy from 1.18.0 to 1.18.1 (visgl#25) Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.18.0 to 1.18.1. - [Release notes](https://github.com/http-party/node-http-proxy/releases) - [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md) - [Commits](http-party/node-http-proxy@1.18.0...1.18.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump node-fetch from 2.6.0 to 2.6.1 (visgl#26) Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: RaymondDashWu <33266041+RaymondDashWu@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
RaymondDashWu
added a commit
to RaymondDashWu/hubble.gl
that referenced
this pull request
Nov 3, 2020
… an animation for some datasets (visgl#15) * Upgrade packages, downgrade node (for now) (visgl#14) Pinning node to version 12.6.3 per discussion. Upgrading to deck 8.2.2 * Improve App Integration: Make Camera and Layers Optional in a DeckScene (visgl#15) * Minor keyframe class clean up, removing unused defaults * Camera and Layers are optional in a DeckScene - Animating the camera is optional, but if a keyframe is defined then viewState is controlled by camera keyframe. - To Use: do not provide a `camera` to `keyframes` parameter when constructing DeckScene. - Animating layers is optional, only replace layers prop when scene provides layers. - To Use: do not provide a `renderLayers` parameter when constructing DeckScene * Adding Camera Example to docs * [FIX/ADD] Fixed missing steps to instructions + added extra notation (visgl#13) * [FIX/ADD] Fixed missing steps to instructions + added extra notation * [FIX] Forgot missing step in visgl#8 * [FIX/ADD] Fix step 9 and added clarification * [DEL] Extraneous folders/files * Adding a ResolutionGuide component to examples...(visgl#17) ...so the background doesn't look so empty. * v1.1.0-alpha.3 (visgl#18) * v1.1.0-alpha.4 * Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com> * Bump elliptic from 6.5.2 to 6.5.3 Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](indutny/elliptic@v6.5.2...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com> * Initial commit. Mini kepler example but not connected to Redux * [BLOCKED] Can't connect to Kepler's Redux store * [BLOCKED] Can't connect to Redux * lint (visgl#28) * v1.1.0-alpha.5 * Documentation fixes additions (visgl#21) * [FIX/ADD] Fixed missing steps to instructions + added extra notation * [FIX] Forgot missing step in visgl#8 * [FIX/ADD] Fix step 9 and added clarification * [DEL] Extraneous folders/files * [TEST] Is this how you link markdown images? * [ADD] Rendering tips/guide * [FIX] Separated GIF/MP4 so it can't be interpreted together * [FIX] Made steps more clear by bolding and fixed sequence conversion to gif not mp4 * [FIX?] Image not loading * [FIX] MP4 => GIF error * [FIX] Spacing between Step #s * [FIX] Step visgl#4 spacing * [FIX/ADD] Removed MP4 from docs + added entry to table of contents * [MOVE] Images move to website static folder + location updated * [FIX] Image URLS * Bump http-proxy from 1.18.0 to 1.18.1 (visgl#25) Bumps [http-proxy](https://github.com/http-party/node-http-proxy) from 1.18.0 to 1.18.1. - [Release notes](https://github.com/http-party/node-http-proxy/releases) - [Changelog](https://github.com/http-party/node-http-proxy/blob/master/CHANGELOG.md) - [Commits](http-party/node-http-proxy@1.18.0...1.18.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [BLOCKED] Issues in visgl#12 Codelabs * [FIX] Modal now opens * Bump node-fetch from 2.6.0 to 2.6.1 (visgl#26) Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [BLOCKED] Can't find module ocular.config * [FIX] Webpack config now boots start-local * [FIX] Modal now opens with map but animations bugged * Documentation Grammer Edit (visgl#29) Just a missing comma * [ADD] Incorporated initial view state + default/update keyframes * [FIX] Updated keyframes were wrong bug * [REFACTOR] Created new panel-preview + scene now consistent with hubble's scene * Mapbox And Deck.gl Canvas Merged When Exported With Hubble.gl In Example Trips (visgl#31) * Mapbox and Deck.gl canvas merged when exported with Hubble.gl Co-authored-by: Chris Gervang <chrisgervang@users.noreply.github.com> * [FIX] updateCamera temporary fix * [FIX/REFACTOR] updateCamera now updates keyframe, parseSetCameraType now a generic util * [FIX/CLEAN] Bug where keyframes weren't updating properly + cleaned dead code in preparation to merge to master * [CLEAN] Removed unused code, packages, + lint fixes Co-authored-by: Chris Gervang <chrisgervang@users.noreply.github.com> Co-authored-by: Chris Gervang <chris@gervang.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chris Gervang <chr@uber.com> Co-authored-by: Vitor Dino <vitor@kunstdesign.com.br> Co-authored-by: Elisa Martinez <97morningstar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rare situations when a canvas is captured before an animation frame is finished, toDataUrl can return a nearly empty string. It is useful to warn when this happens, but it is no longer considered an error since proper usage of the library guarantees the canvas is captured appropriately.
The only time we expect this nearly empty string is when capturing a truly empty frame, such as a transparent PNG when deckgl doesn't have anything to render.
A regression could reintroduce this issue, especially when @deck.gl/mapbox support is added (fusing canvases is a fragile operation).
See a before and after example on gdrive