From 18bb2c83963feb952b48a76165840e473c43b235 Mon Sep 17 00:00:00 2001 From: Xiaoji Chen Date: Sun, 17 Mar 2024 15:56:15 -0700 Subject: [PATCH] add comments --- modules/webgl/src/adapter/resources/webgl-command-buffer.ts | 1 + modules/webgl/src/adapter/resources/webgl-framebuffer.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/modules/webgl/src/adapter/resources/webgl-command-buffer.ts b/modules/webgl/src/adapter/resources/webgl-command-buffer.ts index c2741811a..d7d05602c 100644 --- a/modules/webgl/src/adapter/resources/webgl-command-buffer.ts +++ b/modules/webgl/src/adapter/resources/webgl-command-buffer.ts @@ -183,6 +183,7 @@ function _copyTextureToBuffer(device: WebGLDevice, options: CopyTextureToBufferO ); } finally { device.gl.bindBuffer(GL.PIXEL_PACK_BUFFER, null); + // prevHandle may be unassigned if the try block failed before binding if (prevHandle !== undefined) { device.gl.bindFramebuffer(GL.FRAMEBUFFER, prevHandle); } diff --git a/modules/webgl/src/adapter/resources/webgl-framebuffer.ts b/modules/webgl/src/adapter/resources/webgl-framebuffer.ts index bbe34aff3..ad3cee24d 100644 --- a/modules/webgl/src/adapter/resources/webgl-framebuffer.ts +++ b/modules/webgl/src/adapter/resources/webgl-framebuffer.ts @@ -40,7 +40,7 @@ export class WEBGLFramebuffer extends Framebuffer { this.autoCreateAttachmentTextures(); /** Attach from a map of attachments */ - // @ts-expect-error + // @ts-expect-error native bindFramebuffer is overridden by our state tracker const prevHandle: WebGLFramebuffer | null = this.gl.bindFramebuffer( GL.FRAMEBUFFER, this.handle