chore(shadertools): Fully eliminate implicit typings #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
changed the title
ibgreen
force-pushed
the
shadertools-types
branch
from
584506c
to
f9bc122
Compare
ibgreen
force-pushed
the
shadertools-types
branch
from
f9bc122
to
93e7746
Compare
ibgreen
force-pushed
the
shadertools-types
branch
from
e4f986b
to
a805125
Compare
felixpalmer
reviewed
Nov 22, 2022
| }; | ||
|
|
||
| const TYPE_DEFINITIONS = { | ||
| const TYPE_DEFINITIONS: Record<string, {validate: (value: unknown, propType: PropType) => boolean}> = { |
There was a problem hiding this comment.
I think this would be better called VALIDATOR or similar
There was a problem hiding this comment.
That is a good idea, addressed in #1679
| const propTypes: Record<string, PropType> = {}; | ||
|
|
||
|
|
||
| export function parsePropTypes(propDefs: Record<string, PropType>): Record<string, PropDef> { |
There was a problem hiding this comment.
I find the types and parameter naming confusing. It's not clear why you chose to swap the names of the types but kept the parameter names.
There was a problem hiding this comment.
Good catch. Overhauled in same PR #1679
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1402
Background
Change List
noImplicitAnyin shadertools module