[core] Restore tests for CommandBuffer#copyTextureToBuffer #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Dec 8, 2023
donmccurdy
force-pushed
the
donmccurdy/remove-BufferWithAccessor
branch
from
dbb7c56
to
52f690a
Compare
Base automatically changed from
donmccurdy/remove-BufferWithAccessor
to
master
December 8, 2023 20:12
donmccurdy
force-pushed
the
donmccurdy/command-buffer-tests
branch
from
fc90ddc
to
13d154d
Compare
Remove use of and changes to TEXTURE_FORMATS
donmccurdy
force-pushed
the
donmccurdy/command-buffer-tests
branch
from
13d154d
to
c229b9f
Compare
|
@ibgreen I noticed that this PR was also marked as a net loss in coverage, despite only adding tests: Perhaps that's mostly explained by running tests in Node.js and without WebGL 2, as these new tests are skipped for coverage. But it is unexpected that Coveralls calls out uncovered lines in test files under |
|
Thanks for digging into this. Check out https://github.com/visgl/luma.gl/blob/master/nyc.config.js. We probably need to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small but important fixes for CommandBuffer#copyTextureToBuffer, and restoring unit tests on that function. This PR is currently based on #1864, I'll hold it open until that is merged.