Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): luma.attachDevice() #2013

Merged
merged 3 commits into from
Mar 7, 2024
Merged

feat(core): luma.attachDevice() #2013

merged 3 commits into from
Mar 7, 2024

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Mar 7, 2024 •
edited
Loading

For #

Background

  • useful to be able to attach WebGL contexts without importing webgl module

Change List

  • luma.attachDevice
  • docs
  • tests

@ibgreen ibgreen marked this pull request as ready for review March 7, 2024 21:06
@ibgreen ibgreen merged commit 8410a44 into master Mar 7, 2024
1 check passed
@ibgreen ibgreen deleted the ib/attach-device branch March 7, 2024 21:07
chrisgervang
chrisgervang reviewed Mar 7, 2024
View reviewed changes
docs/api-reference/core/luma.md
### `luma.attachDevice()`

```ts
luma.attachDevice(handle: WebGLRenderingContext | GPUDevice, devices: unknown[])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebGL2RenderingContext?

ibgreen added a commit that referenced this pull request Mar 13, 2024
@ibgreen
feat(core): luma.attachDevice() (#2013)
2be8939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgervang chrisgervang chrisgervang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibgreen @chrisgervang