fix(webgl): Render pass parameter handling #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibgreen
approved these changes
Apr 1, 2024
| @@ -58,7 +55,7 @@ export class WEBGLRenderPass extends RenderPass { | |||
| * Maps RenderPass parameters to GL parameters | |||
| */ | |||
| setParameters(parameters: RenderPassParameters = {}): void { | |||
| const glParameters: GLParameters = {}; | |||
| const glParameters: GLParameters = {...this.glParameters}; | |||
There was a problem hiding this comment.
Note that only four specifically documented parameters can be changed after creation in a RenderPass (blend constant, stencil reference, scissor rect and viewport). Other parameters are frozen.
We should not be touching framebuffer, writeMask, stencilMask etc here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change List
popContextStatealready restores framebuffer binding to what it was beforebeginRenderPass(). Should not mutate global state.WEBGLRenderPass.setParameters(): partially modify, not replace,glParameters