fix(webgl): Support instanceCount=0 in draw() #2070
Merged
+56
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am starting to think that the current API that detects instancing by checking whether instanceCount is a number is perhaps too subtle. |
| @@ -489,9 +497,22 @@ export class Model { | |||
| */ | |||
| setInstanceCount(instanceCount: number): void { | |||
| this.instanceCount = instanceCount; | |||
| if (instanceCount > 0) { | |||
| this.isInstanced = true; | |||
| } | |||
There was a problem hiding this comment.
I would expect this to work the other way, i.e.
if (this.isInstanced) {
this.instanceCount = instanceCount;
}
There was a problem hiding this comment.
This was added as I didn't wan't to break existing luma.gl examples.
modules/engine/src/model/model.ts
Outdated
| this.vertexCount = vertexCount; | ||
| this.setNeedsRedraw('vertexCount'); | ||
| /** Specify whether instanced rendering should be used */ | ||
| setInstanced(isInstanced: boolean = true): void { |
There was a problem hiding this comment.
Do we need this? Is there a realistic scenario that switches between instanced/non-instance without changing the attribute layout?
There was a problem hiding this comment.
Good point. In fact, I believe that whether the model is instanced should be detectable from the attribute layout, (stepMode: 'instance'). I should to dig into that before landing this.
Pessimistress
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #visgl/deck.gl#8776
Background
Change List