Fix to not save to savedMap when reuseMaps is false#1555
Merged
Pessimistress merged 3 commits intovisgl:masterfrom Sep 6, 2021
Merged
Fix to not save to savedMap when reuseMaps is false#1555Pessimistress merged 3 commits intovisgl:masterfrom
Pessimistress merged 3 commits intovisgl:masterfrom
Conversation
src/mapbox/mapbox.js
Outdated
| } | ||
|
|
||
| if (!Mapbox.savedMap) { | ||
| if (props.reuseMaps && !Mapbox.savedMap) { |
Collaborator
There was a problem hiding this comment.
This is going to break an external use case where finalize() is called without arguments. Can you save reuseMaps in setProps instead?
Contributor
Author
There was a problem hiding this comment.
Thanks for the review!
I changed it as shown in 936cbb1.
Pessimistress
pushed a commit
that referenced
this pull request
Sep 7, 2021
Pessimistress
pushed a commit
that referenced
this pull request
Sep 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for the great library.
I have been using this library and noticed that when the Map is unmounted, the worker remains even if reuseMaps is false.
In this PR, I changed it so that when the Map is unmounted, if reuseMaps is false, it will not be saved in savedMap.