New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask user for video quality preference to download #4

Open
vishnugt opened this Issue Jan 19, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@vishnugt
Owner

vishnugt commented Jan 19, 2018

Users should be able to select the video quality.
He should also have the freedom to set up the default quality and also an option to edit his default choice

@deferred

This comment has been minimized.

Contributor

deferred commented Jan 29, 2018

@vishnugt Can I take this? If the user doesn't have a default choice set, should he be prompted each time he copies youtube URL to the clipboard with the choices available from youtube-dl?

@vishnugt

This comment has been minimized.

Owner

vishnugt commented Jan 29, 2018

Yeah sure, you can take it. If the user doesn't have a default choice set, then lets not pass anything to YouTube-dl, it will automatically download the highest quality available.

@vishnugt

This comment has been minimized.

Owner

vishnugt commented Jan 30, 2018

We should try to validate the user input and give him some examples of video quality.
Some might be unaware of what we mean by quality and may give "720" or "1080" as input, which is wrong. So some sort of validation should be done.

@vishnugt vishnugt reopened this Jan 30, 2018

@deferred

This comment has been minimized.

Contributor

deferred commented Jan 30, 2018

Youtube-dl will not download if the input is wrong, so will another validation be needed? We can add the config to the project, and we can copy-paste some examples from README file, so the user knows how to edit the config.

@vishnugt

This comment has been minimized.

Owner

vishnugt commented Feb 2, 2018

I was thinking of maybe informing the user if he inputs a non-valid format, but I guess we can skip that since youtube-dl automatically does that. And yeah, some examples should be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment