Skip to content
This repository

improvement: dont require('redis') if client is passed in (which will allow support for haredis) #56

Closed
nickminutello opened this Issue August 30, 2012 · 1 comment

1 participant

nickminutello
nickminutello

If you allow the redis client to be passed in, there shouldnt be any need to depend on redis module. Should just require('redis') in a lazy fashion.

ie:

    this.client = options.client || new redis.createClient(options.port || options.socket, options.host, options);

should be

    this.client = options.client || new require('haredis').createClient(options.port || options.socket, options.host, options);

For what its worth : haredis: https://github.com/carlos8f/haredis

nickminutello

Any thoughts?

Chirag chirag04 closed this in 30d7013 October 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.