Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Debug output is unreadable using solarized dark color scheme in Terminal #52

Closed
nikmartin opened this Issue · 5 comments

2 participants

@nikmartin

It looks like your color scheme is meant for solarized light, because when using solarized dark, the debug text is the same color as the background.
screenshot from 2013-06-28 01 04 34

@lymanlai

ya, I am using ubuntu and also using this color scheme and it is also not work.

@lymanlai

just find out the problem.
at the solarized color scheme

at here: https://github.com/visionmedia/debug/blob/master/lib/debug.js#L118
"\u001b[90m" this value is the same as the background color
after my test, the colors can have better visual is 31-37,91-97
so, need to change the "\u001b[90m" to "\u001b[91m" then it will work

@nikmartin

Have you tested against Solarized Light and Dark? Are your suggested changes pleasant defaults in both?

@lymanlai

here is the screenshot on my end: ubuntu terminal solarized scheme

screenshot from 2013-07-01 01 12 48

u can check out my fork: https://github.com/lymanlai/debug ( I also change some code to make the code better understand )

@lymanlai

actually the "\u001b[90m" means the "color palette 9" u can hover on the color palette block, will show up the tooltip of the color palette.
then u will find out the "\u001b[90m" just the same color as the background, that is why we can not read the text
image

@TooTallNate TooTallNate closed this issue from a commit
@TooTallNate TooTallNate node: reset terminal color for the debug content
This is a controversial change as well, but it seems to be
wanted by the community, and usability is more important to me
than looks, so why not…

Closes #47.
Closes #52.
Closes #87.
9e4e0ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.